From 405a92e926a342de3ae46c97d9cbf18eed758d36 Mon Sep 17 00:00:00 2001 From: Matiss Janis Aboltins <matiss@mja.lv> Date: Sun, 2 Apr 2023 20:21:22 +0100 Subject: [PATCH] :white_check_mark: (e2e) improve stability of budget e2e tests (#845) Sometimes the test failed because.. `parseFloat("1,234.55") === 1)` --- .../desktop-client/e2e/page-models/budget-page.js | 12 +++++++----- upcoming-release-notes/845.md | 6 ++++++ 2 files changed, 13 insertions(+), 5 deletions(-) create mode 100644 upcoming-release-notes/845.md diff --git a/packages/desktop-client/e2e/page-models/budget-page.js b/packages/desktop-client/e2e/page-models/budget-page.js index dfbe2bfb8..3af42c338 100644 --- a/packages/desktop-client/e2e/page-models/budget-page.js +++ b/packages/desktop-client/e2e/page-models/budget-page.js @@ -35,11 +35,13 @@ export class BudgetPage { async getBalanceForRow(idx) { return Math.round( parseFloat( - await this.budgetTable - .getByTestId('row') - .nth(idx) - .getByTestId('balance') - .textContent(), + ( + await this.budgetTable + .getByTestId('row') + .nth(idx) + .getByTestId('balance') + .textContent() + ).replace(/,/g, ''), ) * 100, ); } diff --git a/upcoming-release-notes/845.md b/upcoming-release-notes/845.md new file mode 100644 index 000000000..01229ed0f --- /dev/null +++ b/upcoming-release-notes/845.md @@ -0,0 +1,6 @@ +--- +category: Maintenance +authors: [MatissJanis] +--- + +Improve stability of budget e2e test file -- GitLab