From 37d391b4fc583a6f3f68196dcc624aca0b2148d4 Mon Sep 17 00:00:00 2001
From: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>
Date: Wed, 18 Sep 2024 06:27:47 -0700
Subject: [PATCH] Do not allow renaming to an empty category or group name
(#3463)
* Do not allow renaming to an emoty category or group name
* Release notes
---
.../src/components/modals/CategoryGroupMenuModal.tsx | 2 +-
.../src/components/modals/CategoryMenuModal.tsx | 2 +-
upcoming-release-notes/3463.md | 6 ++++++
3 files changed, 8 insertions(+), 2 deletions(-)
create mode 100644 upcoming-release-notes/3463.md
diff --git a/packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx b/packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx
index b79d4667d..abdcba1fd 100644
--- a/packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx
+++ b/packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx
@@ -45,7 +45,7 @@ export function CategoryGroupMenuModal({
const notes = useNotes(group.id);
const onRename = newName => {
- if (newName !== group.name) {
+ if (newName && newName !== group.name) {
onSave?.({
...group,
name: newName,
diff --git a/packages/desktop-client/src/components/modals/CategoryMenuModal.tsx b/packages/desktop-client/src/components/modals/CategoryMenuModal.tsx
index e17f43edb..721759fca 100644
--- a/packages/desktop-client/src/components/modals/CategoryMenuModal.tsx
+++ b/packages/desktop-client/src/components/modals/CategoryMenuModal.tsx
@@ -43,7 +43,7 @@ export function CategoryMenuModal({
const originalNotes = useNotes(category.id);
const onRename = newName => {
- if (newName !== category.name) {
+ if (newName && newName !== category.name) {
onSave?.({
...category,
name: newName,
diff --git a/upcoming-release-notes/3463.md b/upcoming-release-notes/3463.md
new file mode 100644
index 000000000..e0b748028
--- /dev/null
+++ b/upcoming-release-notes/3463.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [joel-jeremy]
+---
+
+Mobile - Do not allow renaming category or group to an empty name.
--
GitLab