From 2c6cca6bf663b67aebe70cc07f6c7653ca51ad59 Mon Sep 17 00:00:00 2001
From: Jed Fox <git@jedfox.com>
Date: Mon, 19 Jun 2023 06:41:49 -0400
Subject: [PATCH] Improve error logging in the API (#1121)
---
packages/loot-core/src/server/api.ts | 3 +++
packages/loot-core/src/server/cloud-storage.ts | 3 ++-
upcoming-release-notes/1121.md | 6 ++++++
3 files changed, 11 insertions(+), 1 deletion(-)
create mode 100644 upcoming-release-notes/1121.md
diff --git a/packages/loot-core/src/server/api.ts b/packages/loot-core/src/server/api.ts
index 9485c6fba..85ad5183b 100644
--- a/packages/loot-core/src/server/api.ts
+++ b/packages/loot-core/src/server/api.ts
@@ -176,6 +176,9 @@ handlers['api/download-budget'] = async function ({ syncId, password }) {
}
} else {
let files = await handlers['get-remote-files']();
+ if (!files) {
+ throw new Error('Could not get remote files');
+ }
let file = files.find(f => f.groupId === syncId);
if (!file) {
throw new Error(
diff --git a/packages/loot-core/src/server/cloud-storage.ts b/packages/loot-core/src/server/cloud-storage.ts
index 6c7cc80b5..6a4f0aced 100644
--- a/packages/loot-core/src/server/cloud-storage.ts
+++ b/packages/loot-core/src/server/cloud-storage.ts
@@ -348,11 +348,12 @@ export async function listRemoteFiles() {
},
});
} catch (e) {
- console.log('Error', e);
+ console.log('Unexpected error fetching file list from server', e);
return null;
}
if (res.status === 'error') {
+ console.log('Error fetching file list from server', res);
return null;
}
diff --git a/upcoming-release-notes/1121.md b/upcoming-release-notes/1121.md
new file mode 100644
index 000000000..2a6117ed1
--- /dev/null
+++ b/upcoming-release-notes/1121.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [j-f1]
+---
+
+Improve error reporting when using the API
--
GitLab