From 0a61acdf8f82bdcf6be7f384a50b45af95213ea4 Mon Sep 17 00:00:00 2001
From: shall0pass <20625555+shall0pass@users.noreply.github.com>
Date: Tue, 11 Oct 2022 12:48:08 -0500
Subject: [PATCH] Remove the hold for future months button
---
packages/api/app/bundle.api.js | 1 -
packages/loot-core/src/client/actions/queries.js | 9 ---------
packages/loot-core/src/server/budget/app.js | 5 -----
.../src/components/budget/rollover/BudgetSummary.js | 12 ------------
4 files changed, 27 deletions(-)
diff --git a/packages/api/app/bundle.api.js b/packages/api/app/bundle.api.js
index c77f4610f..74323be47 100644
--- a/packages/api/app/bundle.api.js
+++ b/packages/api/app/bundle.api.js
@@ -52962,7 +52962,6 @@ app.method('budget/set-zero', Object(_mutators__WEBPACK_IMPORTED_MODULE_1__["mut
app.method('budget/set-3month-avg', Object(_mutators__WEBPACK_IMPORTED_MODULE_1__["mutator"])(Object(_undo__WEBPACK_IMPORTED_MODULE_2__["undoable"])(_actions__WEBPACK_IMPORTED_MODULE_3__["set3MonthAvg"])));
app.method('budget/set-all-future', Object(_mutators__WEBPACK_IMPORTED_MODULE_1__["mutator"])(Object(_undo__WEBPACK_IMPORTED_MODULE_2__["undoable"])(_actions__WEBPACK_IMPORTED_MODULE_3__["setAllFuture"])));
app.method('budget/hold-for-next-month', Object(_mutators__WEBPACK_IMPORTED_MODULE_1__["mutator"])(Object(_undo__WEBPACK_IMPORTED_MODULE_2__["undoable"])(_actions__WEBPACK_IMPORTED_MODULE_3__["holdForNextMonth"])));
-app.method('budget/hold-for-future-months', Object(_mutators__WEBPACK_IMPORTED_MODULE_1__["mutator"])(Object(_undo__WEBPACK_IMPORTED_MODULE_2__["undoable"])(_actions__WEBPACK_IMPORTED_MODULE_3__["holdForFutureMonths"])));
app.method('budget/reset-hold', Object(_mutators__WEBPACK_IMPORTED_MODULE_1__["mutator"])(Object(_undo__WEBPACK_IMPORTED_MODULE_2__["undoable"])(_actions__WEBPACK_IMPORTED_MODULE_3__["resetHold"])));
app.method('budget/cover-overspending', Object(_mutators__WEBPACK_IMPORTED_MODULE_1__["mutator"])(Object(_undo__WEBPACK_IMPORTED_MODULE_2__["undoable"])(_actions__WEBPACK_IMPORTED_MODULE_3__["coverOverspending"])));
app.method('budget/transfer-available', Object(_mutators__WEBPACK_IMPORTED_MODULE_1__["mutator"])(Object(_undo__WEBPACK_IMPORTED_MODULE_2__["undoable"])(_actions__WEBPACK_IMPORTED_MODULE_3__["transferAvailable"])));
diff --git a/packages/loot-core/src/client/actions/queries.js b/packages/loot-core/src/client/actions/queries.js
index 2fa3fc8ba..7bd94c7d7 100644
--- a/packages/loot-core/src/client/actions/queries.js
+++ b/packages/loot-core/src/client/actions/queries.js
@@ -24,21 +24,12 @@ export function applyBudgetAction(month, type, args) {
case 'set-3-avg':
await send('budget/set-3month-avg', { month });
break;
- case 'set-all-future':
- await send('budget/set-all-future', { startMonth: month });
- break;
case 'hold':
await send('budget/hold-for-next-month', {
month,
amount: args.amount
});
break;
- case 'hold-all-future':
- await send('budget/hold-for-future-months', {
- startMonth: month,
- amount: args.amount
- });
- break;
case 'reset-hold':
await send('budget/reset-hold', { month });
break;
diff --git a/packages/loot-core/src/server/budget/app.js b/packages/loot-core/src/server/budget/app.js
index 2ef9ea936..60eb58ff6 100644
--- a/packages/loot-core/src/server/budget/app.js
+++ b/packages/loot-core/src/server/budget/app.js
@@ -12,15 +12,10 @@ app.method(
);
app.method('budget/set-zero', mutator(undoable(actions.setZero)));
app.method('budget/set-3month-avg', mutator(undoable(actions.set3MonthAvg)));
-app.method('budget/set-all-future', mutator(undoable(actions.setAllFuture)));
app.method(
'budget/hold-for-next-month',
mutator(undoable(actions.holdForNextMonth))
);
-app.method(
- 'budget/hold-for-future-months',
- mutator(undoable(actions.holdForFutureMonths))
-);
app.method('budget/reset-hold', mutator(undoable(actions.resetHold)));
app.method(
'budget/cover-overspending',
diff --git a/packages/loot-design/src/components/budget/rollover/BudgetSummary.js b/packages/loot-design/src/components/budget/rollover/BudgetSummary.js
index 715c8ed11..b8eff1f3f 100644
--- a/packages/loot-design/src/components/budget/rollover/BudgetSummary.js
+++ b/packages/loot-design/src/components/budget/rollover/BudgetSummary.js
@@ -204,10 +204,6 @@ function ToBudget({ month, prevMonthName, collapsed, onBudgetAction }) {
name: 'buffer',
text: 'Hold for next month'
},
- {
- name: 'buffer-future',
- text: 'Hold for all future months'
- },
{
name: 'reset-buffer',
text: "Reset next month's buffer"
@@ -224,14 +220,6 @@ function ToBudget({ month, prevMonthName, collapsed, onBudgetAction }) {
}}
/>
)}
- {state.menuOpen === 'buffer-future' && (
- <HoldTooltip
- onClose={() => setState({ menuOpen: null })}
- onSubmit={amount => {
- onBudgetAction(month, 'hold-all-future', { amount });
- }}
- />
- )}
{state.menuOpen === 'transfer' && (
<TransferTooltip
initialAmountName="leftover"
--
GitLab