From 06b2a8757ed3ec96e2be24a5a4e33e2a02c43333 Mon Sep 17 00:00:00 2001 From: Matiss Janis Aboltins <matiss@mja.lv> Date: Tue, 13 Jun 2023 20:47:59 +0100 Subject: [PATCH] :bug: (nordigen) perform status check only if server is online (#1127) Small bugfix for nordigen. Do not perform the server status check if the user is actually offline. --- packages/desktop-client/src/hooks/useNordigenStatus.ts | 9 +++++++-- upcoming-release-notes/1127.md | 6 ++++++ 2 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 upcoming-release-notes/1127.md diff --git a/packages/desktop-client/src/hooks/useNordigenStatus.ts b/packages/desktop-client/src/hooks/useNordigenStatus.ts index 7915a6c8b..c619eba4b 100644 --- a/packages/desktop-client/src/hooks/useNordigenStatus.ts +++ b/packages/desktop-client/src/hooks/useNordigenStatus.ts @@ -2,9 +2,12 @@ import { useEffect, useState } from 'react'; import { send } from 'loot-core/src/platform/client/fetch'; +import useSyncServerStatus from './useSyncServerStatus'; + export default function useNordigenStatus() { const [configured, setConfigured] = useState<boolean | null>(null); const [isLoading, setIsLoading] = useState(false); + const [status] = useSyncServerStatus(); useEffect(() => { async function fetch() { @@ -16,8 +19,10 @@ export default function useNordigenStatus() { setIsLoading(false); } - fetch(); - }, [setConfigured, setIsLoading]); + if (status === 'online') { + fetch(); + } + }, [status]); return { configured, diff --git a/upcoming-release-notes/1127.md b/upcoming-release-notes/1127.md new file mode 100644 index 000000000..eef301d51 --- /dev/null +++ b/upcoming-release-notes/1127.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [MatissJanis] +--- + +Nordigen: do not perform status check if server is offline -- GitLab