From 05754d3e4227e01215c632281f54038bb729ce26 Mon Sep 17 00:00:00 2001 From: Matiss Janis Aboltins <matiss@mja.lv> Date: Wed, 14 Jun 2023 18:13:57 +0100 Subject: [PATCH] :bug: (nordigen) expired bank-links (#1133) Further Nordigen fixes for expired bank-links. With the recent changes to the router, we had broken this functionality. <img width="488" alt="Screenshot 2023-06-14 at 09 00 21" src="https://github.com/actualbudget/actual/assets/886567/8e7516e0-121a-46e0-9e52-24748b161173"> <img width="437" alt="Screenshot 2023-06-14 at 09 00 30" src="https://github.com/actualbudget/actual/assets/886567/88b36549-1073-4269-b42f-1553c164316f"> --- .../src/components/accounts/AccountSyncCheck.js | 8 ++------ packages/desktop-client/src/hooks/useNordigenStatus.ts | 2 +- upcoming-release-notes/1133.md | 6 ++++++ 3 files changed, 9 insertions(+), 7 deletions(-) create mode 100644 upcoming-release-notes/1133.md diff --git a/packages/desktop-client/src/components/accounts/AccountSyncCheck.js b/packages/desktop-client/src/components/accounts/AccountSyncCheck.js index 61b32573d..74a54bb65 100644 --- a/packages/desktop-client/src/components/accounts/AccountSyncCheck.js +++ b/packages/desktop-client/src/components/accounts/AccountSyncCheck.js @@ -1,5 +1,6 @@ import React, { useState } from 'react'; import { connect } from 'react-redux'; +import { useParams } from 'react-router-dom'; import * as actions from 'loot-core/src/client/actions'; @@ -50,17 +51,12 @@ function getErrorMessage(type, code) { } function AccountSyncCheck({ - id, accounts, failedAccounts, - syncAndDownload, - markAccountSuccess, unlinkAccount, pushModal, - closeModal, - getAccounts, - addNotification, }) { + let { id } = useParams(); let [open, setOpen] = useState(false); if (!failedAccounts) { return null; diff --git a/packages/desktop-client/src/hooks/useNordigenStatus.ts b/packages/desktop-client/src/hooks/useNordigenStatus.ts index c619eba4b..e93e87d6a 100644 --- a/packages/desktop-client/src/hooks/useNordigenStatus.ts +++ b/packages/desktop-client/src/hooks/useNordigenStatus.ts @@ -7,7 +7,7 @@ import useSyncServerStatus from './useSyncServerStatus'; export default function useNordigenStatus() { const [configured, setConfigured] = useState<boolean | null>(null); const [isLoading, setIsLoading] = useState(false); - const [status] = useSyncServerStatus(); + const status = useSyncServerStatus(); useEffect(() => { async function fetch() { diff --git a/upcoming-release-notes/1133.md b/upcoming-release-notes/1133.md new file mode 100644 index 000000000..6d0b28fee --- /dev/null +++ b/upcoming-release-notes/1133.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [MatissJanis] +--- + +Nordigen: fix bank-sync expiry functionality -- GitLab